Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo machete #5410

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix cargo machete #5410

merged 1 commit into from
Dec 1, 2024

Conversation

lucasmerlin
Copy link
Collaborator

@lucasmerlin lucasmerlin commented Nov 28, 2024

  • I have followed the instructions in the PR template

cargo machete depends on cargo-platform which seems to bumped it's msrv. Installing via --locked should fix this for now. I think it's fine to do this manually instead of using the cargo action since it's so simple and the action we used basically did the same (without --locked)

@lucasmerlin lucasmerlin added the CI Continues Integration test label Nov 28, 2024
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5410-lucas/fix-machete
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@emilk emilk merged commit 7e3275c into master Dec 1, 2024
46 of 47 checks passed
@emilk emilk deleted the lucas/fix-machete branch December 1, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continues Integration test exclude from changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants