Use TextBuffer
for layouter
in TextEdit
instead of &str
#5712
+27
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
layouter
to use theTextBuffer
instead of&str
in the closure. It is necessary when layout decisions depend on more than just the raw string content, such as metadata stored in the concrete type implementingTextBuffer
.In our use case, we needed this to support mention highlighting when a user selects a mention. Since mentions can contain spaces, determining mention boundaries from the
&str
alone is impossible. Instead, we use theTextBuffer
implementation to retrieve the correct bounds.See the video below for a demonstration:
Screen.Recording.2025-02-11.at.4.30.13.PM.mov
Breaking change
This PR introduces a breaking change to the
layouter
function inTextEdit
.Previous API:
New API:
Impact on Existing Code
• Any existing usage of
layouter
will no longer compile.• Callers must update their closures to use
&dyn TextBuffer
instead of&str
.Migration Guide
Before:
After: