Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Windows Stability #5723

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rustbasic
Copy link
Contributor

Dear emilk,

Programs built with egui on Windows are terminating every hour on average.
When this commit is applied, it works fine for about 6 hours on average.

I've been testing it for over 6 months and have submitted multiple PRs since 6 months ago,
but they haven't applied it yet.

Thank you.

Copy link

Preview available at https://egui-pr-preview.github.io/pr/5723-patch160
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@lucasmerlin
Copy link
Collaborator

Can you explain why this change makes a difference? And what was changed for which reason? I tried to understand it from the diff but I can't make sense of it.

@lucasmerlin lucasmerlin added native-windows Running on native Windows OS egui labels Feb 18, 2025
@rustbasic
Copy link
Contributor Author

Can you explain why this change makes a difference? And what was changed for which reason? I tried to understand it from the diff but I can't make sense of it.

In Windows, the run_ui_and_paint() function is called when it's EventResult::Wait.
Previously, the return value of the run_ui_and_paint() function was ignored.
This is a modification to apply the return value of the run_ui_and_paint() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui native-windows Running on native Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants