implement vertical slider orientation #875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a vertical orientation for
Slider
. Closes #589.What's new
SliderOrientation
with variantsHorizontal
andVertical
.orientation
to set the slider orientationnew_vertical
andfrom_get_set_vertical
to instantiate with vertical orientation.What's changed
orientation
instead. Some functions and parameters are renamed (e.g.x_range
->position_range
).Slider
which match on the Slider's orientation.Alternatives
.orientation
mutator function (instead of changing or creating constructor functions).