Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow borrowing plot points via PlotPoints::Borrowed #64

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Allow borrowing plot points via PlotPoints::Borrowed #64

merged 6 commits into from
Feb 5, 2025

Conversation

bircni
Copy link
Contributor

@bircni bircni commented Jan 7, 2025 •
edited
Loading

As #35 seems to be inactive
I fixed the remaining issues

@bircni bircni changed the title update env_logger Allow borrowing plot points Jan 7, 2025
@bircni
Copy link
Contributor Author

bircni commented Feb 4, 2025

@emilk maybe include this in egui_plot 0.31.0 ?

@lucasmerlin lucasmerlin added enhancement New feature or request include in changelog This change will be included in the changelog labels Feb 5, 2025
lucasmerlin
lucasmerlin approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I wonder if we still need the owned variant at all?

@bircni
Copy link
Contributor Author

bircni commented Feb 5, 2025

hmm maybe not - might lead to a new issue for the next release?

@lucasmerlin
Copy link
Collaborator

hmm maybe not - might lead to a new issue for the next release?

Yeah, definitely not for this release, but might be worth another look in the future

@lucasmerlin lucasmerlin merged commit 7628355 into emilk:main Feb 5, 2025
9 of 10 checks passed
@lucasmerlin lucasmerlin changed the title Allow borrowing plot points Allow borrowing plot points via PlotPoints::Borrowed Feb 5, 2025
@bircni bircni deleted the point_borrow branch February 5, 2025 08:30
@mo8it
Copy link
Contributor

mo8it commented Feb 5, 2025

@bircni thanks for the continuation :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmerlin lucasmerlin lucasmerlin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request include in changelog This change will be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bircni @lucasmerlin @mo8it