cross-platform fetch_async #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
May 9, 2023
Vrixyz
commented
Jun 8, 2023
| @@ -2,6 +2,9 @@ use std::collections::BTreeMap; | |||
|
|
|||
| use crate::{Request, Response}; | |||
|
|
|||
| #[cfg(feature = "native-async")] | |||
| use async_channel::{Receiver, Sender}; | |||
|
|
|||
| /// Only available when compiling for native. | |||
| /// | |||
| /// NOTE: Ok(…) is returned on network error. | |||
There was a problem hiding this comment.
is it different from web ? should we add this note to every fetch* ?
There was a problem hiding this comment.
No, it is the same on web.
Ok: we got a response, whatever it was
Err: we failed to make the request
I'll update the docs post-merge
emilk
approved these changes
Jun 13, 2023
| @@ -2,6 +2,9 @@ use std::collections::BTreeMap; | |||
|
|
|||
| use crate::{Request, Response}; | |||
|
|
|||
| #[cfg(feature = "native-async")] | |||
| use async_channel::{Receiver, Sender}; | |||
|
|
|||
| /// Only available when compiling for native. | |||
| /// | |||
| /// NOTE: Ok(…) is returned on network error. | |||
There was a problem hiding this comment.
No, it is the same on web.
Ok: we got a response, whatever it was
Err: we failed to make the request
I'll update the docs post-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use this crate in an async context, and only wasm had this capability ; my approach is quite naïve but it makes the API easier to use.
Thanks for considering :)