Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Improve opaque network error message #33

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Web: Improve opaque network error message #33

merged 3 commits into from
Sep 12, 2023

Conversation

jprochazk
Copy link
Collaborator

@jprochazk jprochazk commented Sep 12, 2023 •
edited by emilk
Loading

Removes the big stacktrace, and points the user to look at the browser developer console

Part of emilk/egui#3291

@jprochazk jprochazk mentioned this pull request Sep 12, 2023
Closed
emilk
emilk reviewed Sep 12, 2023
View reviewed changes
ehttp/src/web.rs Outdated Show resolved Hide resolved
emilk
emilk approved these changes Sep 12, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice; thank you!

@jprochazk
Copy link
Collaborator Author

Can't merge in this repo 😄

@emilk emilk changed the title Web: Simplify opaque network errors Web: Improve opaque network error message Sep 12, 2023
emilk
emilk reviewed Sep 12, 2023
View reviewed changes
ehttp/src/web.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit e2fa26e into emilk:master Sep 12, 2023
8 checks passed
@emilk emilk mentioned this pull request Dec 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprochazk @emilk