Skip to content

Commit

Permalink
fix: disable threaded console when we use fork
Browse files Browse the repository at this point in the history
This is similar to ocaml#8100 for the threaded console. The reason we're
doing that is to avoid threads when fork is involved.

Signed-off-by: Etienne Millon <me@emillon.org>
  • Loading branch information
emillon committed Jul 6, 2023
1 parent bb06683 commit a53cb5e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Unreleased
----------

- Disable background operations on MacOS and other Unixes where we rely on
fork. (#8100, fixes #8083, @rgrinberg)
- Disable background operations and threaded console on MacOS and other Unixes
where we rely on fork. (#8100, #8121, fixes #8083, @rgrinberg, @emillon)

- Add `dune build --dump-gc-stats FILE` argument to dump Garbage Collection
stats to a named file. (#8072, @Alizter)
Expand Down
2 changes: 1 addition & 1 deletion src/dune_config/config.ml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ let threaded_console =
let t =
{ name = "threaded_console"
; of_string = Toggle.of_string
; value = `Enabled
; value = background_default
}
in
register t;
Expand Down

0 comments on commit a53cb5e

Please sign in to comment.