Broaden allowed syntax for DSL #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now a command must start with a keyword. This has been relaxed
and a command can now start with a keyword, a symbol, or a string.
This means that all of the following are legal ways to represent a
click:
[click] [:click] ["click"] (click) (:click) ("click")
|
Since rudimentary error handling is being introduced anyway, it'd be nice to print a list of legal commands if an illegal one is encountered. All of these can be formatted into a nice string like so: (->> process-event
(.getMethodTable)
(map first)
(remove (partial = :default))
(sort)
(clojure.string/join ", ")) |
#30 Using a wrong command name will now produce an error message including the names of all currently implemented commands. This is fetched dynamically by inspecting the MultiFn and should always be up to date.
| (defmethod process-event :click | ||
| (comp name first)) | ||
|
|
||
| (defn valid-commands |
There was a problem hiding this comment.
This is not really an IO-related function, and it should really have a docstring.
#30 The function to look up functions contained in a multimethod has been moved to a utils namespace and now sports a proper docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now a command must start with a keyword. This has been relaxed and a command can now start with a keyword, a symbol, or a string.
This means that all of the following are legal ways to represent a
click:
[click][:click]["click"](click)(:click)("click")This closes #30.