Handle process cgroup paths containng ':' #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cgroup paths containing ':' will cause `Process::cgroups` to return an
incomplete pathname. The reason is that parsing the fields in
`/proc/self/cgroup` is perform with `.split(':')`. If something as
follows is set:
```bash
mkdir /sys/fs/cgroup/memory/foo:bar
echo $$ > /sys/fs/cgroup/memory/foo:bar/tasks
cat /proc/self/cgroup
...
8:memory:/foo:bar
...
```
the resulting `ProcessCgroup` will have a `pathname` equal to just `/foo`.
This patch addresses this by taking the remainer of the line after the
second ':' as the pathname. This is safe because `cgroups(7)` describes
`/proc/self/cgroup` as only having 3 fields.
eminence
approved these changes
Oct 14, 2021
|
Nice find and nice fix, thanks! |
|
Hi @alfonsoros88, the latest v0.11.0 release contains your fix for this issue. Thanks again |
|
@eminence thanks a lot! that was fast :) |
|
There were several other pending fixes that needed to be released, so your fix was just some good extra motivation to cut the release :) |
This was referenced Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cgroup paths containing ':' will cause
Process::cgroupsto return anincomplete pathname. The reason is that parsing the fields in
/proc/self/cgroupis perform with.split(':'). If something asfollows is set:
the resulting
ProcessCgroupwill have apathnameequal to just/foo.This patch addresses this by taking the remainer of the line after the
second ':' as the pathname. This is safe because
cgroups(7)describes/proc/self/cgroupas only having 3 fields.