Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 32bit signed int #153

Merged
merged 1 commit into from
Oct 31, 2021
Merged

fix: 32bit signed int #153

merged 1 commit into from
Oct 31, 2021

Conversation

tatref
Copy link
Contributor

@tatref tatref commented Oct 18, 2021

Previous code had some issues...

called `Result::unwrap()` on an `Err` value: Other("Value in `Key: Value` pair was not actually a number")

Hex values should be interpreted as a 32bits two's complement signed int

@eminence eminence merged commit 3cb30c3 into eminence:master Oct 31, 2021
@eminence
Copy link
Owner

I just published v0.11.1 that contains only this fix. I'll also be publishing v0.12.0 fairly soon (which will also contain this fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eminence eminence eminence left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatref @eminence