Support drops column in /proc/net/udp #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dergecko
force-pushed
the
feat/include_drops_in_proc_net_udp
branch
3 times, most recently
from
9f98ff6
to
d436d4a
Compare
|
Thanks! Can you check the CI build failures? |
added 2 commits
October 25, 2024 08:24
… can be read Kernels prior to 2.6.27 do not provide a drops column for /proc/net/udp therefore a check is introduced to validate the current kernel version before reading the column Add kernel version to SystemInfoInterface
dergecko
force-pushed
the
feat/include_drops_in_proc_net_udp
branch
from
d436d4a
to
fcdc85e
Compare
|
I'm working on it |
|
Sorry, too less coffee this morning. I will ping you when it's ready for review! |
In rust 1.80 compile-time checks for unkown features are introduced. Therefore workspace lints for unkown features are enabled.
dergecko
force-pushed
the
feat/include_drops_in_proc_net_udp
branch
from
5f4510a
to
d256c6d
Compare
|
Ok I fixed the CI build failures, but had to add some functionality to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Kernel 2.6.27 the kernel reports drops on udp sockets.
I created this merge request to include the named column as I can become in handy.
The official man page does not list the udp drops column however the feature was introduces a long time ago.
Kernel commit: torvalds/linux@cb61cb9
Please let me know if I should change anything on the PR or if I missed something important, as this is my first PR here.
How was this PR tested?
I added unit tests for parsing the
/proc/net/udpprior and after kernel version 2.6.27