Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android support #95

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Add Android support #95

merged 1 commit into from
Sep 23, 2020

Conversation

fabricedesre
Copy link
Contributor

This adds support for android targets. Changes needed are:

  • use the android specific version of the MetadataExt trait.
  • use libc::mode_t instead of hardcoding the type for file modes (it's a u16 on 32bit Android targets).

@eminence
Copy link
Owner

LGTM, thanks!

I'm not an expert in android development, so a quick question for you: do you have any recommendations on testing android in CI? Is running cargo check --target aarch64-linux-android sufficient? Or are there other targets that should be also checked?

@fabricedesre
Copy link
Contributor Author

Yes, running cargo check --target aarch64-linux-android is a good way to verify the Rust parts, while not having to deal with the link phase which is more annoying because you need an android sysroot.

@eminence
Copy link
Owner

Ok great. I'll add that later. Thank you!

@eminence eminence merged commit a616c55 into eminence:master Sep 23, 2020
@eminence eminence added this to the v0.9.0 milestone Oct 4, 2020
@eminence
Copy link
Owner

This has now been published on crates.io as v0.9.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants