-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from winapi to windows-sys. #32
Conversation
This PR migrates terminal_size from winapi to windows-sys. Windows-sys is actively maintained, by Microsoft, and has recently started to be adopted in the ecosystem; mio, parking_lot, wasmtime, and others have moved to windows-sys. Migrating terminal_size to windows-sys will help me remove one more of Wasmtime's transitive dependencies on winapi.
Thanks. It's neat how small this patch is. This is obviously a fully semver-compatible change, so I'm inclined to release this as patch version bump ( |
Ah, it seems that this change bumps the MSRV from 1.31 to 1.35. Normally this would be fine and I would just release a new |
I took a look at some of the most popular crates that depend on (click to see boring details)
(A random grumble to myself: I keep feeling that my attempts at maintaining a MSRV policy ends up being not worth the hassle, given how little of the ecosystem seems to care about MSRVs) |
I believe it bumps the MSRV to 1.48. I'm unable to build this with windows-sys on 1.47 but I am on 1.48. I've now updated the crate documentation to reflect that.
A semver bump would be less convenient for wasmtime, but not the worst. It'll be a while before all the transitive dependencies migrate to window-sys in any case.
1.48 is the version in Debian stable and I use it as an MSRV in several crates I maintain, as I've found it's kind of a "sweet spot" that's reasonably old at this point while being not too much of a burden to maintain as an MSRV. |
Hmm, I know your other rustix PR will bump all the way to 1.48, but I think this PR only bumps to 1.35. I just checked again and I can run Ok, here's what I'm going to do: I going to drop 02d8428 from this PR (since it will conflict with #33 ), merge both PRs, and then release a v0.2 release |
Released on crates.io as |
This PR migrates terminal_size from winapi to windows-sys.
Windows-sys is actively maintained, by Microsoft, and has recently
started to be adopted in the ecosystem; mio, parking_lot, wasmtime,
and others have moved to windows-sys.
Migrating terminal_size to windows-sys will help me remove one more of
Wasmtime's transitive dependencies on winapi.