Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait makeable not found #144

Closed
OmarMarie opened this issue Feb 24, 2021 · 9 comments
Closed

Trait makeable not found #144

OmarMarie opened this issue Feb 24, 2021 · 9 comments

Comments

@OmarMarie
Copy link

Trait 'Laravel\Nova\Makeable' not found at /var/www/laravel/dashboard/vendor/eminiarts/nova-tabs/src/Tab.php:20

@OmarMarie OmarMarie changed the title Makeable not found Trait makeable not found Feb 24, 2021
@RVxLab
Copy link
Collaborator

RVxLab commented Feb 24, 2021

This is not particularly helpful.

Make sure the trait exists or provide more info.

@kfvit-andreaskviby
Copy link

Hey, this has just happened to me as well.

[2021-03-07 12:57:24] local.ERROR: Trait 'Laravel\Nova\Makeable' not found {"userId":1,"exception":"[object] (Symfony\Component\Debug\Exception\FatalErrorException(code: 1): Trait 'Laravel\Nova\Makeable' not found at /Users/andreaskviby/Code/wulffcrm2/vendor/eminiarts/nova-tabs/src/Tab.php:20)

There is nothing except Laravel Nova that has been updated and this happens.

If I go into the Tab.php file and just comment out the use Makeable trait it works as nothing has happened but on production server this handy little fix does not work.

I have just published a large update to our CRM and this breaks all company pages inside Nova using Tabs. Do you have any idea on how to fix this.

@RVxLab
Copy link
Collaborator

RVxLab commented Mar 7, 2021

@kfvit-andreaskviby What version of Nova are you using?

I would've checked the sources in the repo, but they're no longer accessible.

2 people with this issue makes me think I'm targeting a version of Nova higher than intended.

RVxLab added a commit that referenced this issue Mar 7, 2021
@kfvit-andreaskviby
Copy link

Hey there!
I believe this is something that will occur on an old version of Nova but still you will have to remove the use Makeable on new versions of Nova to make your tabs work as intended.

I am nov using Laravel Nova 2.12 and when removing use Makeable in Tab.php it works.

@RVxLab
Copy link
Collaborator

RVxLab commented Mar 7, 2021

I am nov using Laravel Nova 2.12

More or less what I was suspecting. I didn't realize that Makeable wasn't available until some time in 3.x.

Please check the referenced commit above, I'll publish 1.4.3 soon.

@kfvit-andreaskviby
Copy link

Fantastic work! Both here and on Filament :)

@RVxLab
Copy link
Collaborator

RVxLab commented Mar 7, 2021

Thanks! But I don't do anything on Filament (yet).

@kfvit-andreaskviby
Copy link

Ah, okey. My misstake :)

@RVxLab
Copy link
Collaborator

RVxLab commented Mar 7, 2021

I just tagged 1.4.3 that fixes this issue.

I'm sorry for the inconvenience this caused, I was not aware that Makeable was not available until 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants