Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete images if using Tabs in a resource with TabsOnEdit #28

Closed
AliNetmatter opened this issue Mar 16, 2019 · 12 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@AliNetmatter
Copy link

When trying to delete an image the URL the delete call is made to does not include the correct resource id.

As an example, the call is made to
/nova-api/products/undefined/field/image
where undefined should be replaced with the resource ID.

@muckypuddle-nick
Copy link

+1

1 similar comment
@phucnguyenvn
Copy link

+1

@SadeghPM
Copy link

+1 and same issue

@preliot
Copy link

preliot commented Apr 8, 2020

+1 Seems to go wrong in Laravel\Nova\Http\Controllers\FieldDestroyController.php on line 28

(If you don't need an image to be deleteable, you can use ->deleteable(false) to disallow deletion. Use ->prunable() to automatically delete the file when the associated record is deleted).

@DerekBuntin
Copy link

This issue is still happening to me, as soon as I removed TabsOnEdit the images deleted successfully.

@bernhardh
Copy link
Contributor

Yes. Still an issue

@RVxLab RVxLab self-assigned this Oct 19, 2020
@RVxLab
Copy link
Collaborator

RVxLab commented Oct 19, 2020

I'll try to take a look at it this week.

@RVxLab RVxLab added the bug Something isn't working label Oct 21, 2020
@MikeCraig418
Copy link

Thanks @RVxLab !

@Yann-BUTSCHER-EIRL
Copy link

Hello.
Do you have any updates on this ?

As much as we like your package, this kind of bugs makes us wonder if it would be easier to not use it.

Thanks anyway for all the work you've put in it.

@RVxLab
Copy link
Collaborator

RVxLab commented Nov 15, 2020

Okay first of all, I'm sorry that I took this long to address this issue. Poor form on my part.

As for the issue, yes I found the problem and implemented a fix, see #59 and commit 55237f3.

I'm tagging 1.3.1 with this fix.

@RVxLab RVxLab closed this as completed Nov 15, 2020
@amidesfahani
Copy link

+1 and same issue

@TomOudeRengerink
Copy link

Hey any updates on this? @RVxLab you mentioned it fixed in #59. Does not seems to work (anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests