Fixed the deletion of a file

[chinleung]

This PR fixes laravel/nova-issues#1936 by updating the updateFields method in Eminiarts\Tabs\TabsOnEdit to return a Eminiarts\Tabs\FieldCollection, which extends Laravel\Nova\Fields\FieldCollection instead of a regular Illuminate\Support\Collection to have access to findFieldByAttribute method.

Also overwritten the method of whereInstanceOf to search through the fields in the tabs instead of the first level element.

[ibrunotome]

Hello @bajramemini, can you merge this to solve the bug on TabsOnEdit?

[bolechen]

Hello @bajramemini, can you merge this to solve the bug on TabsOnEdit?

[RVxLab]

Hey! Sorry it took this long for a response.

This has become quite a big PR, I'd need to have a look locally first.

[RVxLab]

This seems to have been fixed in #62 and #63, can you check with version 1.2.3 of this package?

[golonix]

I'm using Nova 3.14.0 and the issue still exists. With FieldCollection class from this MR, it works as expected.

[RVxLab]

@golonix Thanks for confirming this. I'll look into merging this soon.

[RVxLab]

Thanks for your PR :)