Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not work in nova v2.7.0 #62

Closed
loveyuxiao opened this issue Nov 13, 2019 · 11 comments
Closed

not work in nova v2.7.0 #62

loveyuxiao opened this issue Nov 13, 2019 · 11 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@loveyuxiao
Copy link

not work in nova v2.7.0
@loveyuxiao
Copy link
Author

Argument 2 passed to App\Nova\ResourceUser::assignToPanels() must be an instance of Laravel\Nova\Fields\FieldCollection, instance of Illuminate\Support\Collection given, called in /home/ad/www/laravel6/vendor/laravel/nova/src/ResolvesFields.php on line 197

@Francois-Francois
Copy link
Contributor

PR is sent. @bajramemini able to try, merge and tag please ?
#63

@kosmonowt
Copy link
Contributor

oops. 12 minutes to late. here as well:
#64

@Francois-Francois
Copy link
Contributor

@kosmonowt #64 (comment)

bajramemini added a commit that referenced this issue Nov 13, 2019
@bajramemini
Merge pull request #63 from rikless/fix27
0e192e0 
close #62
@sohaibafifi
Copy link

Not working on relations for me. They are displayed at the bottom.

@Francois-Francois
Copy link
Contributor

@sohaibafifi Right. Don't know why at this point. Seems related to nova.

@Francois-Francois Francois-Francois mentioned this issue Nov 13, 2019
Closed
@Francois-Francois
Copy link
Contributor

So, when a tab contains a HasMany type, it breaks the expected behavior. Any idea @bajramemini ?

@bajramemini
Copy link
Contributor

Hello everyone

Had a lot to do last week, will try to get this fixed this week. Not sure what is causing the problem yet. If anyone has an idea, please let me know.

@bajramemini bajramemini added bug Something isn't working help wanted Extra attention is needed labels Nov 24, 2019
@bajramemini bajramemini reopened this Nov 24, 2019
@Francois-Francois
Copy link
Contributor

@bajramemini it's a nova related issue. It will be patched in Nova 2.7.2 or 2.8.0, you don't have to do anything.

@Francois-Francois
Copy link
Contributor

Confirmed, fixed in nova 2.8

@bajramemini
Copy link
Contributor

Awesome, thanks @rikless

@RVxLab RVxLab mentioned this issue Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sohaibafifi @kosmonowt @Francois-Francois @bajramemini @loveyuxiao