Rework span completion to support adding props #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
Closes #167
This PR reworks the
SpanGuard
type to not rely on the props typeP
on its resulting span. This means we can changeP
while the span executes, such as by pushing properties to it, without needing to rewrite its completion function.I've also made span completion take
&mut self
, so you can use guards and do manual completion as well as automatic result completion without them conflicting.