fix(305)Panic when receive bad packet #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Just to be sure, could you rerun the benchmarks and make sure they're not negatively affected. |
|
@kelindar here is benchmark result: goos: linux
goarch: amd64
pkg: github.com/emitter-io/emitter/internal/network/mqtt
BenchmarkPublishEncode-8 20000000 97.9 ns/op 0 B/op 0 allocs/op
BenchmarkPublishDecode-8 10000000 239 ns/op 960 B/op 2 allocs/op
BenchmarkConnectDecode-8 10000000 136 ns/op 192 B/op 2 allocs/op
PASS
ok github.com/emitter-io/emitter/internal/network/mqtt 6.203s |
kelindar
approved these changes
Mar 5, 2020
Florimond
pushed a commit
that referenced
this pull request
Sep 7, 2023
* use slice index instead of copy of 2 value in range * fix #305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #305