apacheGH-39525: [C++][Parquet] Pass memory pool to decoders

emkornfield · Jan 9, 2024 · 5051714 · 5051714
1 parent 5acf67c
commit 5051714
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/cpp/src/parquet/column_reader.cc b/cpp/src/parquet/column_reader.cc
@@ -760,7 +760,7 @@ class ColumnReaderImplBase {
 
  if (page->encoding() == Encoding::PLAIN_DICTIONARY ||
  page->encoding() == Encoding::PLAIN) {
- auto dictionary = MakeTypedDecoder<DType>(Encoding::PLAIN, descr_);
+ auto dictionary = MakeTypedDecoder<DType>(Encoding::PLAIN, descr_, pool_);
  dictionary->SetData(page->num_values(), page->data(), page->size());
 
  // The dictionary is fully decoded during DictionaryDecoder::Init, so the
@@ -884,19 +884,20 @@ class ColumnReaderImplBase {
  } else {
  switch (encoding) {
  case Encoding::PLAIN: {
- auto decoder = MakeTypedDecoder<DType>(Encoding::PLAIN, descr_);
+ auto decoder = MakeTypedDecoder<DType>(Encoding::PLAIN, descr_, pool_);
  current_decoder_ = decoder.get();
  decoders_[static_cast<int>(encoding)] = std::move(decoder);
  break;
  }
  case Encoding::BYTE_STREAM_SPLIT: {
- auto decoder = MakeTypedDecoder<DType>(Encoding::BYTE_STREAM_SPLIT, descr_);
+ auto decoder =
+ MakeTypedDecoder<DType>(Encoding::BYTE_STREAM_SPLIT, descr_, pool_);
  current_decoder_ = decoder.get();
  decoders_[static_cast<int>(encoding)] = std::move(decoder);
  break;
  }
  case Encoding::RLE: {
- auto decoder = MakeTypedDecoder<DType>(Encoding::RLE, descr_);
+ auto decoder = MakeTypedDecoder<DType>(Encoding::RLE, descr_, pool_);
  current_decoder_ = decoder.get();
  decoders_[static_cast<int>(encoding)] = std::move(decoder);
  break;
@@ -905,20 +906,22 @@ class ColumnReaderImplBase {
  throw ParquetException("Dictionary page must be before data page.");
 
  case Encoding::DELTA_BINARY_PACKED: {
- auto decoder = MakeTypedDecoder<DType>(Encoding::DELTA_BINARY_PACKED, descr_);
+ auto decoder =
+ MakeTypedDecoder<DType>(Encoding::DELTA_BINARY_PACKED, descr_, pool_);
  current_decoder_ = decoder.get();
  decoders_[static_cast<int>(encoding)] = std::move(decoder);
  break;
  }
  case Encoding::DELTA_BYTE_ARRAY: {
- auto decoder = MakeTypedDecoder<DType>(Encoding::DELTA_BYTE_ARRAY, descr_);
+ auto decoder =
+ MakeTypedDecoder<DType>(Encoding::DELTA_BYTE_ARRAY, descr_, pool_);
  current_decoder_ = decoder.get();
  decoders_[static_cast<int>(encoding)] = std::move(decoder);
  break;
  }
  case Encoding::DELTA_LENGTH_BYTE_ARRAY: {
  auto decoder =
- MakeTypedDecoder<DType>(Encoding::DELTA_LENGTH_BYTE_ARRAY, descr_);
+ MakeTypedDecoder<DType>(Encoding::DELTA_LENGTH_BYTE_ARRAY, descr_, pool_);
  current_decoder_ = decoder.get();
  decoders_[static_cast<int>(encoding)] = std::move(decoder);
  break;