Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed client session bug #12

Merged
merged 1 commit into from
May 23, 2022

Conversation

Arjentix
Copy link
Contributor

Hello!
I was using your library (very helpful) and found out that I always get this message in the stdout:

Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x1254bfa30>

I am sure, that I call close() right. And this message also occurs in your examples.

I've tested my project with changes in this PR and it seems to work fine. I'm not an expert in Python, so maybe I've missed something.

Copy link
Owner

@emlove emlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for the PR!

@emlove emlove merged commit d814df8 into emlove:main May 23, 2022
@emlove
Copy link
Owner

emlove commented May 23, 2022

I've released version 3.1.3 which includes this fix

@Arjentix Arjentix deleted the fix_unclosed_client_session branch May 23, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants