fix: add async-timeout dependency to address loading error #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error:
File "app.py",
line 4, in <module>
from jsonrpc_websocket import Server
File "(snip)/lib/python3.11/site-packages/jsonrpc_websocket/__init__.py",
line 1, in <module>
from .jsonrpc import Server, TransportError # noqa: F401, F403
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "(snip)/lib/python3.11/site-packages/jsonrpc_websocket/jsonrpc.py",
line 7, in <module>
import async_timeout
cause:
Actually async-timeout is using in jsonrpc-websocket, it was not added
to dependency explicitly. But aiohttp depends on async-timeout until
py310, so loading error was not happened until py310. From py311,
aiohttp drop async-timeout dependency, after that jsonrpc-websocket
cause loading error. see also aio-libs/aiohttp#7558 .
|
This fix has been deployed with version 3.1.5. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error:
cause:
Actually async-timeout is using in jsonrpc-websocket, it was not added to dependency explicitly. But aiohttp depends on async-timeout until py310, so loading error was not happened until py310. From py311, aiohttp drop async-timeout dependency, after that jsonrpc-websocket cause loading error. see also aio-libs/aiohttp#7558 .