Add ability to specify INFINITE_TIMEOUT #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thank you for the PR. |
|
Released in 2.0.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @emmanuelsw,
Thanks for the library!
We use it in our project and there are some cases when we want to keep this notification on the screen forever. To do so we specify weird timeouts like
99999999.Looking through the repo I found this discussion #12 and I totally agree that
-1makes a lot of sense to use as "infinite timeout" argument.In this PR I've added
INFINITE_TIMEOUTconst, updated readme and updated the example page.I'm not sure if I should commit dist files too, please let me know if I should. Also let me know if you have better idea on how to implement it.
Thanks!