HashMap: allow valueIterable to be iterated more than once #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterators are stateful and can't be reused. Therefore, the iterator protocol makes Iterable's contain a zero-argument function which creates a new iterator, and re-calls this zero-argument function to create a new iterator every time an iteration starts. hamt.values() returns an iterator which is stateful, so it must be wrapped in a zero-argument function to become an Iterable<T>.
|
Thank you for the pull request! It looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterators are stateful and can't be reused. Therefore, the iterator protocol
makes Iterable's contain a zero-argument function which creates a new iterator,
and re-calls this zero-argument function to create a new iterator every time
an iteration starts.
hamt.values() returns an iterator which is stateful, so it must be wrapped in
a zero-argument function to become an Iterable.