fix utf8 output #74
Closed
fix utf8 output #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actually in the repl : print( b'\xe2\x94\x8c\xe2\x94\x80\xe2\x94\x90'.decode() ) does not ouput ┌─┐ as expected
|
I merged the browser-ui into CPython repo a while ago. Could you please make a PR against https://github.com/python/cpython/blob/main/Tools/wasm/python.html ? |
no it was just a quick fix for here. TTY handling is way more complicated than that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually in the repl :
print( b'\xe2\x94\x8c\xe2\x94\x80\xe2\x94\x90'.decode() )
does not ouput ┌─┐ as expected
it seems xterm.js expects native utf-16 javascript strings.
edit/ if target IS a normal xterm.js probably best to send raw bytes to it instead as in #77