Made AuthMembership, Group, permission customizable through Auth #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hip, group and permission model customizable.
gi0baro
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Thank you for your contribution.
I made some notes to the code you proposed.
Also, I would like to have updated docs for this (see https://github.com/emmett-framework/emmett/blob/master/docs/auth.md)
stricter issubclass check Co-authored-by: Giovanni Barillari <g@baro.dev>
fix: changed order of membership, group and permission to group, membership and permission
added changes to documentation
|
@gi0baro all of the requested changes should have been, tell me if you need any other changes to be made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: exposed models in emmett/tools/auth/init.py and made membership, group and permission model customizable.
this is done by adding auth membership, group, permission to use_database and adding _set_model_config