Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3.12 support #481

Merged
merged 11 commits into from
Dec 21, 2023
Merged

Add python3.12 support #481

merged 11 commits into from
Dec 21, 2023

Conversation

waghanza
Copy link
Contributor

@waghanza waghanza commented Dec 17, 2023

This PR adds support for python 3.12

Closes #480

@gi0baro
Copy link
Member

gi0baro commented Dec 18, 2023

@waghanza for the CI you probably just want to upgrade the setup-python action to latest version, no need to upgrade pip

@waghanza
Copy link
Contributor Author

Seems not @gi0baro

@gi0baro
Copy link
Member

gi0baro commented Dec 18, 2023

Seems not @gi0baro

It seems the version of Poetry is too outdated to handle this, you can try unpin the poetry version (use just @v1), you might also upgrade the rapidjson dependency to latest (1.14)

@waghanza waghanza marked this pull request as ready for review December 18, 2023 21:34
@gi0baro gi0baro merged commit 5ce3db7 into emmett-framework:master Dec 21, 2023
15 checks passed
@waghanza waghanza deleted the python/v3.12 branch December 21, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to install using python version 3.12
2 participants