Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: KeyError if _granian logger is missing in user logging configuration #438

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: KeyError if _granian logger is missing in user logging configuration #438

merged 1 commit into from
Nov 22, 2024

Conversation

monosans
Copy link
Contributor

Minimal example:

from granian import Granian

Granian(target="", log_dictconfig={"loggers": {}}).serve()

@gi0baro gi0baro added this to the 1.6 milestone Nov 22, 2024
@gi0baro
Copy link
Member

gi0baro commented Nov 22, 2024

@monosans thank you for your contribution! ❤️

@gi0baro gi0baro merged commit a6cfc2f into emmett-framework:master Nov 22, 2024
19 checks passed
@monosans monosans deleted the patch-1 branch November 22, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@monosans @gi0baro