feat: add support for logging.NOTSET level #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monosans
commented
Nov 21, 2024
| @@ -23,6 +24,7 @@ class LogLevels(str, Enum): | |||
| LogLevels.warn: logging.WARN, | |||
| LogLevels.info: logging.INFO, | |||
| LogLevels.debug: logging.DEBUG, | |||
| LogLevels.notset: logging.NOTSET, | |||
| } | |||
There was a problem hiding this comment.
We can remove log_levels_map at all and use the LogLevels enum above as a mapping. Let me know if you are interested.
There was a problem hiding this comment.
I'd rather stick with the current approach, I prefer to have this explicit rather than implicit :)
|
@monosans thank you for your contribution ❤️ Gonna merge this as soon as possible, with the 1.7 schedule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Python docs:
logging.NOTSET: When set on a logger, indicates that ancestor loggers are to be consulted to determine the effective level. If that still resolves to NOTSET, then all events are logged.