-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed argument leafs to leaves, with deprecation warning in ontograph #564
Changed argument leafs to leaves, with deprecation warning in ontograph #564
Conversation
…b.com:emmo-repo/EMMOntoPy into 558-ontograph-argument-leafs-should-be-leaves
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 65.85% 66.00% +0.14%
==========================================
Files 16 16
Lines 3099 3112 +13
==========================================
+ Hits 2041 2054 +13
Misses 1058 1058
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! :) You probably need to test the DeprecationWarning
thing locally, once implemented (see comment below).
…b.com:emmo-repo/EMMOntoPy into 558-ontograph-argument-leafs-should-be-leaves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the deprecation warning could be tested (and tested that it still works with leafs
) but I don't consider it a must, to be honest.
Description:
The plural of leaf was written leafs in all arguments etc. Changed it to leaves.
Added a deprecation warning on the tool ontograph, but apart from that did not update with deprecation warnings after discussing the need with @jesper-friis.
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: