Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed argument leafs to leaves, with deprecation warning in ontograph #564

Merged
merged 10 commits into from
Mar 10, 2023

Conversation

francescalb
Copy link
Collaborator

Description:

The plural of leaf was written leafs in all arguments etc. Changed it to leaves.

Added a deprecation warning on the tool ontograph, but apart from that did not update with deprecation warnings after discussing the need with @jesper-friis.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb linked an issue Mar 10, 2023 that may be closed by this pull request
ontopy/ontodoc.py Outdated Show resolved Hide resolved
ontopy/ontodoc.py Outdated Show resolved Hide resolved
ontopy/ontodoc.py Outdated Show resolved Hide resolved
ontopy/ontodoc.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #564 (6d6b73d) into master (5d89725) will increase coverage by 0.14%.
The diff coverage is 82.08%.

❗ Current head 6d6b73d differs from pull request most recent head 366f1e8. Consider uploading reports for the commit 366f1e8 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   65.85%   66.00%   +0.14%     
==========================================
  Files          16       16              
  Lines        3099     3112      +13     
==========================================
+ Hits         2041     2054      +13     
  Misses       1058     1058              
Impacted Files Coverage Δ
ontopy/ontodoc.py 67.51% <64.28%> (ø)
ontopy/utils.py 62.33% <75.00%> (+0.08%) ⬆️
ontopy/ontology.py 70.27% <90.00%> (ø)
ontopy/__init__.py 80.00% <100.00%> (ø)
ontopy/graph.py 62.47% <100.00%> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! :) You probably need to test the DeprecationWarning thing locally, once implemented (see comment below).

ontopy/ontodoc.py Show resolved Hide resolved
tools/ontograph Outdated Show resolved Hide resolved
tools/ontograph Outdated Show resolved Hide resolved
tools/ontograph Outdated Show resolved Hide resolved
francescalb and others added 4 commits March 10, 2023 12:44
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…b.com:emmo-repo/EMMOntoPy into 558-ontograph-argument-leafs-should-be-leaves
Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the deprecation warning could be tested (and tested that it still works with leafs) but I don't consider it a must, to be honest.

@francescalb francescalb merged commit 0794e00 into master Mar 10, 2023
@francescalb francescalb deleted the 558-ontograph-argument-leafs-should-be-leaves branch March 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ontograph - argument leafs should be leaves
3 participants