support PHP8 #10
Merged
support PHP8 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sj-i
changed the title
sj-i
commented
Jan 27, 2021
…ions. # method signatures - sync signatures of PDO methods with PHP8 - PHP8 has named parameters, so also names of parameters should be compatible with parent - change Exception thrown to sync with PHP8 # phpunit - at() was deprecated as of phpunit9.3, so added a polyfill to avoid warnings for now. sebastianbergmann/phpunit#4297 - assertInternalType() was removed in phpunit9. sebastianbergmann/phpunit#3370 - setUp() and tearDown() have return type declaration of void as of phpunit8. sebastianbergmann/phpunit#3288 - @ExpectedException was removed in phpunit9. sebastianbergmann/phpunit#3333
This commit should be reverted when the next version of psalm is released.
|
Please execute php-cs-fixer to fix coding styles. |
- remove redundant @params in phpdocs - migrate mixed from phpdocs to native type declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this PR is not compatible with older versions of PHP.
PHP8 introduces some BC breaks, so supporting both PHP7 and PHP8 in a single code base is no simple task.
The purpose of this PR is to first ask the author about his plans for PHP8.
The choices I can think of are:
a. bump the major to v2 and abandon the support for PHP7
b. bump the major to v2 and continue to support PHP7 in the v1 branch
c. support both versions in a single code base by switching class definitions with phpversion()
The following examples will show you why it is difficult to support both PHP7 and PHP8 in the same class definition.
Changes in this PR
Method signatures
PDOmethods with PHP8Exceptions
phpunit
at()was deprecated as of phpunit9.3, so added a polyfill to avoid warnings for now. Deprecate at() matcher sebastianbergmann/phpunit#4297assertInternalType()was removed in phpunit9. Remove assertInternalType() and assertNotInternalType() sebastianbergmann/phpunit#3370setUp()andtearDown()have return type declaration of void as of phpunit8. Enable void_return fixer sebastianbergmann/phpunit#3288@expectedExceptionwas removed in phpunit9. Remove annotation(s) for expecting exceptions sebastianbergmann/phpunit#3333psalm