-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: remove theming #212
Labels
Comments
@Connorelsea since version 6.0 , you have to opt-in for themeing to use it. |
tkh44
pushed a commit
that referenced
this issue
Aug 3, 2017
closed in #225 |
Personally, I wouldn't mind if import styled from "emotion/react/themed";
export default styled.div`...`; Which would be the equivalent of: import styled from "emotion/react";
import { withTheme } from "theming";
export default withTheme(styled.div`...`); Having converted a large |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm starting to think we should remove built in theming and just let users use the
theming
library themselves. Having theming built in adds overhead and code complexity tostyled
that I don't think is necessary. I prefer to just import my theme file but I may be an outlier.Some notes.
If we remove theming...
Styled
becomes a pure functional component and we can create a factory with createEagerFactory to call it 🔥withTheme
and import it if the user wants theming)The text was updated successfully, but these errors were encountered: