enterkeyhint attribute is filtered by is-prop-valid

[fabb]

Current behavior:

enterKeyHint is a new attribute for input elements. Currently it is being filtered by is-prop-valid and cannot be set on the dom element without a workaround.

const Input = styled.input``

const App = () => (
    <Input enterKeyHint="next" />
)

See styled-components/styled-components#3417

To reproduce:

See styled-components/styled-components#3417

Environment information:

• react version: 17
• @emotion/react version: n/a, using styled-components which itself uses @emotion/is-prop-valid

[Andarist]

Fixing this is quite easy - just add this to the allowlist here: https://github.com/emotion-js/emotion/blob/4be3391914878fd41279701bc23332b75903ec43/packages/is-prop-valid/src/props.js

Would you like to prepare such a change?

[fabb]

Sure, why not. I’ll also check if there are others missing as well: https://github.com/facebook/react/blob/main/packages/react-dom/src/shared/possibleStandardNames.js

[fabb]

ok i compared the possibleStandardNames.js with the props.js and found that these were missing:

• enterKeyHint
• disableRemotePlayback
• icon
• noModule

it looks like disableRemotePlayback and icon are properties but no html element attributes, so i think they can be ignored. noModule is just used on script tags, so it should be irrelevant for css styling. i'll create a PR with just enterKeyHint.

[fabb]

created PR: #2540