Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to babel-plugin-macros #515

Closed
kentcdodds opened this issue Jan 2, 2018 · 3 comments · Fixed by #525
Closed

Upgrade to babel-plugin-macros #515

kentcdodds opened this issue Jan 2, 2018 · 3 comments · Fixed by #525

Comments

@kentcdodds
Copy link
Contributor

The project was renamed from babel-macros to babel-plugin-macros to better support babel v7. No other breaking changes.
@tkh44
Copy link
Member

tkh44 commented Jan 2, 2018 •
edited
Loading

Thanks for letting us know

@kentcdodds
Copy link
Contributor Author

Hopefully we'll finally get this into create-react-app! facebook/create-react-app#3675

@Haroenv
Copy link
Contributor

Haroenv commented Jan 9, 2018

I'll take a look now

Haroenv added a commit to Haroenv/emotion that referenced this issue Jan 9, 2018
@Haroenv
chore: upgrade to babel-plugin-emotion
7cbf80d 
I didn't do __extensive__ testing, but the tests pass and @kentcdodds said there were no breaking changes…

fixes emotion-js#515
@Haroenv Haroenv mentioned this issue Jan 9, 2018
Merged
3 tasks
Haroenv added a commit to Haroenv/emotion that referenced this issue Jan 9, 2018
@Haroenv
chore: upgrade to babel-plugin-emotion
a8c2669 
I didn't do __extensive__ testing, but the tests pass and @kentcdodds said there were no breaking changes…

fixes emotion-js#515
Haroenv added a commit to Haroenv/emotion that referenced this issue Jan 9, 2018
@Haroenv
chore: upgrade to babel-plugin-emotion
d579245 
I didn't do __extensive__ testing, but the tests pass and @kentcdodds said there were no breaking changes…

fixes emotion-js#515
@tkh44 tkh44 closed this as completed in #525 Jan 9, 2018
tkh44 pushed a commit that referenced this issue Jan 9, 2018
@Haroenv
chore: upgrade to babel-plugin-emotion (#525)
d7076e7 
I didn't do __extensive__ testing, but the tests pass and @kentcdodds said there were no breaking changes…

fixes #515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to babel-plugin-macros Haroenv/emotion
3 participants
@tkh44 @kentcdodds @Haroenv