[typescript] Add T param to Matchers interface

[spudly]

This fixes typescript type definitions when using jest-emotion with jest 24.

I simply added a parameter to the Matchers interface in the typescript types file for jest-emotion.

In Jest 24 they added a second generic parameter to the Matchers interface. Typescript requires interfaces to have the same parameters, so jest-emotion needs to add it also.

See DefinitelyTyped/DefinitelyTyped#39982

Checklist:

• [N/A] Documentation
• [N/A] Tests
• Code complete
• Changeset

[changeset-bot]

🦋 Changeset is good to go

Latest commit: b753cbf

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Andarist]

@spudly if this is a requirement (to parameter count to match) - isn't this a breaking change (sort of) for people using older version of jest (or its typings)?

[spudly]

Yes, good point. I guess I'll have to change the changeset...

…

On Fri, Nov 8, 2019, 5:06 PM Mateusz Burzyński ***@***.***> wrote: @spudly <https://github.com/spudly> if this is a requirement (to parameter count to match) - isn't this a breaking change (sort of) for people using older version of jest (or its typings)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1620?email_source=notifications&email_token=AADW5HFQYVVBHG2NX6UCUSLQSXPGJA5CNFSM4JKX5T52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTPQ3Q#issuecomment-552007790>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADW5HEV3QGOS2SKMQ6SGG3QSXPGJANCNFSM4JKX5T5Q> .

[Andarist]

You can target next branch with this PR instead - adjust the changeset to be of type major + upgrade @types/jest deps.

[JakeGinnivan]

Does the dependency on "@types/jest" need to be bumped too?

[Andarist]

Yes, that would require updating as well.

@spudly will you have time to address the code review comments?

[spudly]

Made the requested changes. Ready for review again.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b753cbf:

Sandbox	Source
Emotion	Configuration

[spudly]

sorry, had conflicts. resolved.

[Andarist]

Thanks for this! I should merge this soon.

As a point of reference for anyone interested in this - @types/jest got this second param just very recently (17 days ago) in v24.0.20. https://www.npmjs.com/package/@types/jest/v/24.0.20

cc @JakeGinnivan just as a confirmation - such change is OK as we should get ourselves up-to-date and there is no way to support both, right? I've tried searching if this can somehow be overloaded to match both, but couldn't find a way.