-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest serializer new api #1850
Merged
Merged
Jest serializer new api #1850
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2846169
Remove redundant isTransformed checks
Andarist dc6b5d3
Move cache.add closer to printer call
Andarist 477d388
Drop separate test/print exports from @emotion/jest
Andarist 4448d71
Refactor serializers to use new plugin API
Andarist 8c8ad97
Use stylis to parse & prettify css in @emotion/jest
Andarist 4d65da5
Add @emotion/css-prettifier package
Andarist eaabbc0
One CSS parser to rule them all
Andarist 4056777
Allow to customize indentation in @emotion/css-prettifier
Andarist 55d563e
Fix flow errors
Andarist 31ad66d
Remove print & test from TS @emotion/jest tests
Andarist 89925b8
Add changesets
Andarist 5b15ca5
Merge branch 'stylis-v4' into jest-serializer-new-api
Andarist 0ad7d73
Tweak changeset
Andarist 16fa4be
Update .changeset/breezy-carpets-smile.md
Andarist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@emotion/jest': major | ||
| --- | ||
|
|
||
| `test` & `print` are no longer exported as named exports. If you want to access the default serializer just access the default export. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@emotion/jest': minor | ||
| --- | ||
|
|
||
| Improved printing of nested at-rules. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@emotion/jest': major | ||
| --- | ||
|
|
||
| Refactored to use new serializers API which has been introduced in Jest 21. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@emotion/jest': minor | ||
| --- | ||
|
|
||
| Fixed an issue with all styles being recognized as changed in Jest 25 on unrelated changed. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test&printwere exported so you could add@emotion/jesttosnapshotSerializers, I think I'd like to keep@emotion/jestworking and throw an error when@emotion/jest/serializeris imported that tells people to use@emotion/jestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, isn't it packing too much into a single module? Having a separate entry point for this seems conceptually easier as with
test&printbeing exported we kinda trick Jest to think that it's a serializer - structurally ok-ish but nominally not so much.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, okay, sure. Let's use the seperate module. Could you make the changeset clearer that using the raw package name in the
snapshotSerializersoption will no longer work and they'll have to use@emotion/jest/serializerinstead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this info, could you re-check?