Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with internal buffer being lost for nested factory calls #2013

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

Andarist
Copy link
Member

This fixes a bug reported here: #1955 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2020

🦋 Changeset is good to go

Latest commit: 045d74c

We got this.

This PR includes changesets to release 3 packages
Name Type
@emotion/native Patch
@emotion/primitives Patch
@emotion/primitives-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist requested a review from emmatown September 14, 2020 12:18
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 045d74c:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@1ee8b44). Click here to learn what that means.
The diff coverage is n/a.

Impacted Files Coverage Δ
packages/primitives-core/src/css.js 100.00% <ø> (ø)
scripts/test-utils/legacy-env.js 100.00% <0.00%> (ø)
packages/css-prettifier/src/index.js 100.00% <0.00%> (ø)
packages/sheet/src/index.js 100.00% <0.00%> (ø)
packages/primitives-core/src/styled.js 100.00% <0.00%> (ø)
packages/babel-plugin-jsx-pragmatic/src/index.js 94.11% <0.00%> (ø)
packages/eslint-plugin/src/rules/pkg-renaming.js 100.00% <0.00%> (ø)
packages/server/src/create-instance/inline.js 100.00% <0.00%> (ø)
packages/cache/src/stylis-plugins.js 100.00% <0.00%> (ø)
packages/jest/src/enzyme-serializer.js 100.00% <0.00%> (ø)
... and 75 more

@Andarist Andarist merged commit db16ac3 into next Sep 15, 2020
@Andarist Andarist deleted the fix/buffer-overrides branch September 15, 2020 06:03
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants