-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support typings for Jest v27 #2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b0a0436 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0a0436:
|
|
When will this change be released ? I am looking forward to this change 😄 |
|
I am npm user but this would work with npn7? We would also want to see these relesead, @billyjanitsch if your are busy we caise another pr, rebased with master? |
Yes, this change will remove the peer dependency install error that currently prevents you from running
There's no reason to rebase the branch now. It can be done by a maintainer before merge. This PR is just awaiting review. Please be patient as this project is a volunteer effort. @Andarist whenever you have a moment, could you let me know if you see anything that prevents this from being an easy merge? I don't believe there were any changes to the v27 typings that would affect |
Codecov Report
|
❤️
Hard to assess - we don't have a lot of actual dependency on those types so hopefully this shouldn't be problematic. We'll see after a release, in the worst-case scenario we'll have to do some minor adjustments to make it work with both (that's the hope, at least 😅 ). |
|
We use @emotion/jest with @types/jest v27 for few weeks already, No issues so far beside peer warning during install. |
What:
@emotion/jestis currently only compatible with Jest 26 when using TypeScript because it optionally peer-depends on@types/jest@26:emotion/packages/jest/package.json
Lines 26 to 27 in 4c7b6de
This PR widens the peer dependency range from
^26.0.14to^26.0.14 || ^27.0.0such that both 26 and 27 are supported.Why:
See above.
How:
See above.
Checklist: