Skip to content

add RegExp as typing for target #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2021
Merged

add RegExp as typing for target #2457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caba6da
add RegExp as typing for target
Aug 17, 2021
afd6b75
Create sweet-planes-begin.md
Andarist Oct 8, 2021
b727ac8
Update packages/jest/types/index.d.ts
Andarist Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-planes-begin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@emotion/jest": patch
---

Add `RegExp` as a valid type for the `target` option accepted by `toHaveStyleRule`.
2 changes: 1 addition & 1 deletion packages/jest/src/matchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function toHaveStyleRule(
received: *,
property: *,
value: *,
options?: { target?: string, media?: string } = {}
options?: { target?: string | RegExp, media?: string } = {}
Copy link
Member

@Andarist Andarist Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that you might have wanted to fix in the TS types which are, currently, located here:

emotion/packages/jest/types/index.d.ts

Line 12 in 639b276

target?: string

You have only changed the Flow type here - and we are in the process of replacing Flow with TS.

Copy link
Contributor Author

@jcleefw jcleefw Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made!

) {
const { target, media } = options
const classNames = getClassNamesFromNodes([received])
Expand Down
2 changes: 1 addition & 1 deletion packages/jest/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type SnapshotSerializerPlugin = Extract<
>

export interface StyleRuleOptions {
target?: string
target?: string | RegExp
media?: string
}

Expand Down