Fix error in alternative JS environments #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef0f17a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ef0f17a:
|
emmatown
reviewed
Oct 8, 2021
emmatown
approved these changes
Oct 8, 2021
Looks like eslint is unaware of |
Codecov Report
|
This was referenced Oct 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
globalThisinstead ofwindow || globalwhen checking if multiple copies of@emotion/reactare runningWhy:
Bun.js, a new JS runtime environment I'm working on - one quirk is it reads from the
"browser"field inpackage.json. This improves compatibility for many npm packages, but sometimes breaks stuff.@emotion/reactis one case where that doesn't work, but the fix is simple and also improves@emotion/react's compatibility with web workers (if there is a usecase for that)How:
globalThisis the global context identifier available in all major JavaScript engines newer than Internet Explorer 11. It works in Deno, Node.js 12.0.0+, web workers, web browsers, etc. caniuseFor maximum compatibility, the code checks
globalThisis notundefinedbefore falling back to eitherwindoworglobal(as before).Checklist:
Also I'm not actually sure if a changeset is appropriate here