Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetchpriority prop #2748

Closed
wants to merge 1 commit into from
Closed

Conversation

codejet
Copy link
Contributor

@codejet codejet commented May 15, 2022

What:

Adding the currently still non-standard fetchpriority prop.

Why:

Priority hints are currently an unoffical W3C draft driven by Google (https://wicg.github.io/priority-hints/) but already supported in some Chromium-based browsers (https://caniuse.com/?search=fetchpriority). See also this article: https://web.dev/priority-hints/.

How:

Simply added the prop to packages/is-prop-valid/src/props.js, for now under the "Non-standard Properties".

Checklist:

  • [N/A] Documentation
  • [N/A] Tests
  • Code complete
  • [N/A] Changeset

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2022

⚠️ No Changeset found

Latest commit: 4151544

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4151544:

Sandbox Source
Emotion Configuration

@codejet
Copy link
Contributor Author

codejet commented May 22, 2022

Hi, is there any interest in this? Otherwise I will close it. No hard feelings.

@codejet codejet closed this Jul 16, 2022
@oskareke
Copy link

This is an important SEO feature - could we please get this merged?

@DustinBrett
Copy link
Contributor

@codejet

Hi, is there any interest in this? Otherwise I will close it. No hard feelings.

I see that Styled Components uses @emotion/is-prop-valid to decide if it will show a warning message. I see fetchpriority is considered valid now on https://validator.w3.org/ so I am wondering if we could reopen this PR?

@codejet
Copy link
Contributor Author

codejet commented Jul 15, 2023

@DustinBrett are you a maintainer here? otherwise: as last time there wasn't even a comment, i'm afraid it would be pointless to reopen it.

@DustinBrett
Copy link
Contributor

Ah darn, well maybe one day it will get added. I might make a PR but who knows what will come of it.

@DustinBrett DustinBrett mentioned this pull request Aug 15, 2023
4 tasks
@DustinBrett
Copy link
Contributor

DustinBrett commented Sep 21, 2024

@DustinBrett are you a maintainer here? otherwise: as last time there wasn't even a comment, i'm afraid it would be pointless to reopen it.

It finally happened! #3093
FYI @codejet

@codejet
Copy link
Contributor Author

codejet commented Sep 21, 2024

Thanks @DustinBrett ✌️

I would have never thought that a PR can take 2.5 years 😅

@Andarist
Copy link
Member

I would have never thought I'd maintain OSS projects instead of playing video games after days of full-time work and taking care of my family and kids... but hey, here we are 😉

This slipped through the cracks in the sea of notifications I get, sorry about that.

@codejet
Copy link
Contributor Author

codejet commented Sep 22, 2024

I totally get that @Andarist. I'm grateful to anyone maintaining OSS! I was still surprised to see this change merged 2+ years after I closed my original PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants