Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @types/react as peer deps #3100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ryan-Dia
Copy link

What:
Unlike react in peerDependencies, @types/react can be used with any version.

Why:
This is because @types/react is only listed in peerDependenciesMeta without being explicitly listed in peerDependencies

How:
In peerDependencies, the version for react has been explicitly set to the same version.

Reference
Issues : #3099

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2023

🦋 Changeset detected

Latest commit: 0150753

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@emotion/react Patch
@emotion/styled Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant