Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support array fallback syntax in objects #634

Merged
merged 4 commits into from
Apr 22, 2018
Merged

Support array fallback syntax in objects #634

merged 4 commits into from
Apr 22, 2018

Conversation

emmatown
Copy link
Member

What:

Support array fallback syntax in objects.

let cls = css({ background: ['red', 'linear-gradient(#e66465, #9198e5)'] })

Why:

To make it easier to specify fallbacks in the object syntax and to make it easier for people coming from glamor to use emotion.

How:

Checklist:

  • Documentation
  • Tests
  • Code complete

@emmatown emmatown requested a review from tkh44 April 21, 2018 02:14
@codecov
Copy link

codecov bot commented Apr 21, 2018 •
edited
Loading

Codecov Report

Merging #634 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/create-emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown mentioned this pull request Apr 21, 2018
Closed
@emmatown emmatown merged commit 88a18e5 into master Apr 22, 2018
@emmatown emmatown deleted the support-array-fallback branch April 22, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkh44 tkh44 tkh44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmatown @tkh44