Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-emotion to docs #636

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Add eslint-plugin-emotion to docs #636

merged 4 commits into from
Jun 28, 2018

Conversation

alex-pex
Copy link
Contributor

@alex-pex alex-pex commented Apr 23, 2018

What: Missing eslint plugin docs

Why: To expose the plugin!

How: Using github edit function (I didn't test, I expect the live preview to show if it works) EDIT: it works :)

Checklist:

  • Documentation
  • Tests
  • Code complete

image

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!

@alex-pex
Copy link
Contributor Author

Up!
Everything seems fine, are you waiting for something before merging?

@Ailrun
Copy link
Member

Ailrun commented Jun 27, 2018

@mitchellhamilton @tkh44 Is there any problem with this?

@tkh44
Copy link
Member

tkh44 commented Jun 27, 2018

No. Feel free to merge anything marked with the "merge me" label in the future.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/index.js 96.87% <0%> (ø) ⬆️
packages/emotion-theming/src/theme-provider.js 100% <0%> (ø) ⬆️

@tkh44 tkh44 merged commit c1b19ba into emotion-js:master Jun 28, 2018
@alex-pex alex-pex deleted the patch-1 branch June 29, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants