Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EX-6744 Change history queries confirmation dialog text #155

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

annacv
Copy link
Contributor

@annacv annacv commented Aug 1, 2022

@annacv annacv requested a review from a team as a code owner August 1, 2022 07:21
Copy link
Contributor

@herrardo herrardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the text in this way to not use "you" or "your", but then i realized that we already use that way of communicating with the customer on the My History panel, so in that case, i like better your suggestion:

https://searchbroker.atlassian.net/browse/EX-6743?focusedCommentId=156315

Copy link
Contributor

@CachedaCodes CachedaCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @herrardo, I find If you disable the History Queries feature, your search history will be deleted. better.

@annacv annacv requested review from herrardo and CachedaCodes August 1, 2022 11:23
@CachedaCodes CachedaCodes merged commit d4af982 into main Aug 2, 2022
@CachedaCodes CachedaCodes deleted the EX-6744_History-queries-dialog-txt branch August 2, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants