feat(my-history): close MyHistory when clicking on a suggestion #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnavarroespinosa
deleted the
feature/EX-6742-close-MyHistory-modal-when-clicking-suggestion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EX-6742
Motivation and context
We wanted to be able to close the
MyHistorymodal when the user clicked a history suggestion.Also, we wanted to only show the open
MyHistorybutton when there was no queryType of change
What is the destination branch of this PR?
MainHow has this been tested?
Check that the button to open
MyHistoryappears when there's no query and hides when there is.Click on a history suggestion from
MyHistoryand see that the modal closes.