-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add brands and change query preview #281
Conversation
PR #281 preview deployed in https://x.test.empathy.co/preview/281/index.html |
PR #281 preview deployed in https://x.test.empathy.co/preview/281/index.html |
PR #281 preview deployed in https://x.test.empathy.co/preview/281/index.html |
…d-change-query-preview
PR #281 preview deployed in https://x.test.empathy.co/preview/281/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Beltrán Garcia Balbuena <beltranbalbuena@gmail.com>
PR #281 preview deployed in https://x.test.empathy.co/preview/281/index.html |
PR #281 preview deployed in https://x.test.empathy.co/preview/281/index.html |
Pull request template
Change result.vue to add a new field
Is this correct in terms of Archetype as base for future customers? What happens if a customer has no brand? I did it in the same way as collection.
Motivation and context
Provide better REsult Card and better Recommendations on the Search home
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines:
Checklist: