Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: showing query+ selected related tags in nextQueryPreview #457

Conversation

albertjcuac
Copy link
Contributor

@albertjcuac albertjcuac commented Mar 8, 2024

Pull request template

Since now we take into account related tags for the nextQueries preview, CustomNextQueryPreview component in the archetype should handle the use case of a query + RT when showing what users have searched for.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-3638

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

To test it, you can use env=live and:
1)query=shoulder bag
2)query=shoulder + relatedTag=bag
3)query=shoulder + relatedTag=bag + relatedTag=velvet
Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@albertjcuac albertjcuac requested a review from a team as a code owner March 8, 2024 09:13
@annacv
Copy link
Contributor

annacv commented Mar 11, 2024

Tested applying the same changes in customer (CDL). Works fine. Pending to find out build's break (no break in local)

Copy link

Check PR 457 preview 👀

https://x.test.empathy.co/preview/457/index.html

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@annacv annacv merged commit bc36424 into main Mar 11, 2024
4 checks passed
@annacv annacv deleted the feature/EMP-3638-Update-CustomQueryPreview-in-the-archetype-to-show-both-query-RT-if-so branch March 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants