refactor(staggered-fade-and-slide): use Vue native staggered transition #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorcg88
commented
Jun 27, 2024
Comment on lines
+228
to
+232
| /** | ||
| * Using querySelector to get the root element of the grid instead of using the ref directly | ||
| * because with the introductions of Fragments, Vue returns every DOM element inside the component. | ||
| */ | ||
| rootEl.value = document.querySelector('.x-base-grid'); |
There was a problem hiding this comment.
Related to vuejs/core#4830 and vuejs/core#4830
victorcg88
force-pushed
the
feat/vue3-test-search-component
branch
2 times, most recently
from
c70e931
to
168e296
Compare
victorcg88
force-pushed
the
feat/new-staggered-fade-and-slide-vue3
branch
from
07ec7cd
to
9d634f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
A version of StaggeredFadeAndSlide optimized for Vue3.
Created a new component from the previous
StaggeredFadeAndSliderefactored and simplified using Vue native transitions. TheStaggeringTransitionGroupwill not be needed when upgrading to Vue3.Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: